-
Notifications
You must be signed in to change notification settings - Fork 3
Update dou-asm.md #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update dou-asm.md #8
Conversation
At least add the logo! I know it's looks out of place because of it's white background, but it's better than nothing!
| <tr><td>Platform:</td><td>Windows OS, Mac OS, Linux OS (Java)</td></tr> | ||
| <tr><td>Status:</td><td> | ||
| <p style="color:#B0B000;">Stale</p> | ||
| <p style="color:#B0B000;">Stable</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, the "Status" field refers to the status of the development, not the program. The existing pages only have the statuses Finished, Active Development, Stale, and Abandoned. For example, Cave Editor is also stable, but its status is "Abandoned". Similarly, NX-Engine/Evo are stable, but development is no longer ongoing (until recently, the last commit was about two years ago), so they have the status "Stale".
I'm not sure what criteria the maintainers used to determine the status of the projects, but there is no "Stable" status, and I doubt it's necessary.
| <legend>Doukutsu Assembler:</legend> | ||
| <img src="/wiki/img/engines/cse2-assets/ICON_MINI.png"> | ||
| <legend>Doukutsu Assembler:</legend><br> | ||
| <img width="544" height="64" alt="dasm_banner" src="https://github.com/user-attachments/assets/dc7fb80f-8716-44a8-86d5-0fdbf6760315" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better to add the logo as a file in the img folder and embed it using a relative link (/wiki/img/{IMAGE}) rather than storing it as a GitHub attachment. This is the recommended way to add images (as shown on the example page) and is used on all other pages. Also, the width and height attributes are unnecessary, as their values are already contained in the image itself. And it is better to remove the alt attribute or set it to something like "Doukutsu Assembler Banner" (or logo), as this attribute is intended to describe images for humans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't add it to the img folder, the project owners disallowed permission to add files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can upload files and push commits to the branch of your fork specified in the PR (in this case, patch-10), and then when the PR is merged, all these commits will be accepted too.
At least add the logo! I know it's looks out of place because of it's white background, but it's better than nothing!